fix(memory): defer state mutation in add_provider until schema load succeeds#13224
Open
Magicray1217 wants to merge 1 commit into
Open
fix(memory): defer state mutation in add_provider until schema load succeeds#13224Magicray1217 wants to merge 1 commit into
Magicray1217 wants to merge 1 commit into
Conversation
…ucceeds. Fixes NousResearch#9948 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\n\nMemoryManager.add_provider() mutates internal state (_has_external = True and appends provider to _providers) BEFORE provider.get_tool_schemas() succeeds. If get_tool_schemas() raises, the manager is left in a poisoned half-registered state.\n\n## Fix\n\n- Call get_tool_schemas() first in a try/except\n- Only mutate _has_external and _providers after successful schema load\n- Reuse the loaded schemas list instead of calling get_tool_schemas() redundantly\n\nFixes #9948