fix: rollback MemoryManager state when provider registration fails#10051
Open
nightq wants to merge 6 commits into
Open
fix: rollback MemoryManager state when provider registration fails#10051nightq wants to merge 6 commits into
nightq wants to merge 6 commits into
Conversation
added 6 commits
April 15, 2026 11:41
Fixes NousResearch#9999 Root cause: _sanitize_api_messages compared raw tool_call_id strings without stripping whitespace, causing valid tool results to be treated as orphaned when IDs had leading/trailing spaces. Fix: strip whitespace in _get_tool_call_id_static and when collecting result_call_ids from tool messages.
Fixes NousResearch#9980 Root cause: _send_raw_message hardcoded 'chat_id' as receive_id_type, causing [230001] invalid receive_id errors when sending to user open_ids (prefix 'ou_') or union_ids (prefix 'on_'). Fix: Add _detect_receive_id_type() that checks ID prefix (oc_→chat_id, ou_→open_id, on_→union_id) and use it in _send_raw_message.
Fixes NousResearch#9950 Root cause: Prompts discarded for having no reasoning were not added to completed_in_batch, causing --resume to retry them indefinitely. Fix: Append prompt_index to completed_in_batch before continuing past the discard branch.
… env var Fixes NousResearch#9869 Root cause: Hindsight cloud client had hardcoded 30s timeout, causing hindsight_reflect to fail for longer operations. Fix: Read timeout from HINDSIGHT_TIMEOUT env var with default of 300s.
…t cwd Fixes NousResearch#9949 Root cause: Relative paths in skills.external_dirs were resolved against the process cwd via Path.resolve(), causing inconsistent behavior across CLI/gateway/cron contexts. Fix: Check if the path is relative and resolve it against the config file's parent directory instead of cwd.
Fixes NousResearch#9948 Root cause: add_provider() set _has_external=True and appended to _providers BEFORE calling get_tool_schemas(). If schemas raised, the manager was left in a half-registered state that blocked all future external providers. Fix: Call get_tool_schemas() first and only mutate state after it succeeds.
Collaborator
|
Likely duplicate of #9997 — both fix the same root cause: add_provider() mutates state before schema validation in MemoryManager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failed external provider registration leaving MemoryManager in a poisoned state that blocks all future external providers.
Root Cause
add_provider()mutated_has_external = Trueand appended to_providersbefore callingprovider.get_tool_schemas(). If schema loading raised an exception, the manager retained the failed provider in its list and kept_has_external = True, causing all subsequent external providers to be rejected with "external provider X is already registered".Fix
Load tool schemas before mutating any manager state. Only set
_has_external = Trueand append to_providersafterget_tool_schemas()succeeds.Test Plan
Closes #9948