fix(config): add stale timeout settings (salvage #12675)#12891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #12675 by @helix4u onto current main.
Exposes the non-streaming stale-call watchdog timeout via
config.yaml:providers.<id>.stale_timeout_seconds— provider-wideproviders.<id>.models.<model>.stale_timeout_seconds— per-model overrideLegacy
HERMES_API_CALL_STALE_TIMEOUTenv var still works as fallback; local-endpoint auto-disable preserved when no explicit config is set.Why
Discord report (PaulT):
gpt-5.4onopenai-codexhit the hardcoded 300s non-stream watchdog three times on a 173-msg / 254k-token turn. Raising the env var to 1800s unblocked him, but there was no config.yaml knob. This ships the knob.Changes (+267/-31, 6 files)
hermes_cli/timeouts.py: newget_provider_stale_timeout()mirroringget_provider_request_timeout()run_agent.py:_resolved_api_call_stale_timeout_base()+_compute_non_stream_stale_timeout()resolver (config > env > 300s default)tests/hermes_cli/test_timeouts.py: 5 new tests covering precedence + local-endpoint interactioncli-config.yaml.example, docs updatesValidation
scripts/run_tests.sh tests/hermes_cli/test_timeouts.py→ 12 passedOriginal PR: #12675 — authorship preserved via cherry-pick + rebase-merge.