fix(config): add stale timeout settings#12675
Closed
helix4u wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
config.yamlsupport for the non-streaming stale-call timeout that currently only exists as the legacyHERMES_API_CALL_STALE_TIMEOUTenvironment variable. This lets users tune long-running non-streaming turns per provider or per model without relying on.env, while preserving the existing default behavior and local-endpoint safeguards.Related Issue
Fixes #N/A
Type of Change
Changes Made
providers.<id>.stale_timeout_secondsandproviders.<id>.models.<model>.stale_timeout_secondsconfig resolution inhermes_cli/timeouts.pyrun_agent.pythrough a config-aware resolver with legacyHERMES_API_CALL_STALE_TIMEOUTfallbacktests/hermes_cli/test_timeouts.pycli-config.yaml.exampleand docs to show how to use the new config keys and how they interact with env varsHow to Test
providers.openai-codex.stale_timeout_secondsorproviders.openai-codex.models.gpt-5.4.stale_timeout_secondsin~/.hermes/config.yaml300sscripts/run_tests.sh tests/hermes_cli/test_timeouts.pyscripts/run_tests.sh tests/ -n 4Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Validation completed:
scripts/run_tests.sh tests/hermes_cli/test_timeouts.py->12 passedscripts/run_tests.sh tests/ -n 4->29 failed, 13286 passed, 36 skippedin312.70sThe full-suite failures were outside the files touched by this PR. The failing areas were concentrated in existing DingTalk card tests, Discord/API server defaults, backup/profile wrapper restoration, gateway approval and voice-command tests, Codex CLI model picker tests, web server schema, interrupt/toolset/registry coverage, and a Tirith security test.