fix(models): validate MiniMax models against static catalog#12842
Merged
Conversation
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #12829 by @Tranquil-Flow onto current main.
Summary
hermes model MiniMax-M2.7now succeeds. Previously, validation hard-rejected every MiniMax model because MiniMax's/v1/modelsendpoint returns 404 and commit aeb5313 flipped probe failure from warn-and-accept to hard-reject.Changes
hermes_cli/models.py: newminimax/minimax-cnbranch invalidate_requested_model(), placed before the live probe — mirrors the existing openai-codex pattern. Case-insensitive exact match, case-insensitive auto-correct at 0.9 cutoff, similar-model suggestions at 0.5, unknown names accepted with a warning (catalog may be incomplete).tests/test_minimax_model_validation.py: 7 tests covering exact match, case-insensitivity, near-match suggestion, unknown-model acceptance with warning, and catalog-path-is-taken guard.Validation
tests/test_minimax_model_validation.py+tests/hermes_cli/test_model_validation.py.fetch_api_modelsstubbed to return None: exact/lowercase/uppercase all accepted+recognized,MinMax-M2.7auto-corrects toMiniMax-M2.7, unknown models accepted with the "MiniMax does not expose a /models endpoint" warning, minimax-cn behaves the same.Closes #12611
Closes #12460
Closes #12399
Closes #12547
Supersedes #12564 (duplicate, same root cause, less coverage).