fix(models): validate MiniMax models against static catalog#12829
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
fix(models): validate MiniMax models against static catalog#12829Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a catalog-based validation path for MiniMax models in
_resolve_model_selection(), mirroring the existingopenai-codexpattern. MiniMax does not expose a/modelsAPI endpoint, so the previous code would fall through to a generic "Could not reach API" rejection even for valid model names.Before: Any MiniMax model would be rejected with "Could not reach API" because the API probe to
/v1/modelsalways fails for MiniMax.After: MiniMax models are validated against a static catalog (case-insensitive matching), with:
difflib.get_close_matches)Note: Unlike
openai-codexwhich rejects unknown models (accepted: False), MiniMax accepts unknown models with a warning (accepted: True) because the catalog may not cover all available models and the user's model may still work server-side.How to test
MiniMax-M2.7— should be accepted without warningminimax-m2.7— should be accepted (case-insensitive)MiniMax-Text-01— should auto-correct with suggestionMiniMax-Unknown— should be accepted with warningPlatforms tested
Closes #12611
Closes #12460
Closes #12399
Closes #12547