feat(gateway): accept .epub in the document allowlist#12590
Open
handsdiff wants to merge 1 commit into
Open
Conversation
909378d to
9dcfbc7
Compare
2 tasks
9dcfbc7 to
8da20c0
Compare
8da20c0 to
b75c189
Compare
b75c189 to
d28b022
Compare
The allowlist in gateway/platforms/base.py (shared by telegram, slack, discord, feishu, whatsapp) rejected .epub uploads before they reached the agent, even though the ocr-and-documents skill's marker extractor already handles epub (PDF/DOCX/PPTX/XLSX/HTML/EPUB). Add application/epub+zip so the existing per-platform download/cache paths light up for epub too. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
handsdiff
added a commit
to handsdiff/hermes-agent
that referenced
this pull request
Apr 24, 2026
Same shape as the epub addition (NousResearch#12590). ``SUPPORTED_DOCUMENT_TYPES`` in ``gateway/platforms/base.py`` is the single allowlist used by every platform handler (telegram, slack, discord, feishu, whatsapp) to decide whether to cache an uploaded document. It rejected ``.html`` uploads at the gateway even though the ``ocr-and-documents`` skill's ``marker`` extractor already handles HTML alongside PDF/DOCX/PPTX/XLSX/EPUB. Add both ``.html`` and ``.htm`` → ``text/html`` so users can share saved web pages (Telegram's "share page as file" export, "Save As" HTML, email attachments) and the agent can actually read them. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
d28b022 to
4c2733d
Compare
13 tasks
|
@alt-glitch when do you expect this to be merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.epub → application/epub+ziptoSUPPORTED_DOCUMENT_TYPESingateway/platforms/base.py..epubattachments on any of them.Unsupported document type '.epub'— even though theocr-and-documentsskill's marker extractor already lists EPUB as a first-class input alongside PDF/DOCX/PPTX/XLSX/HTML.tests/gateway/test_document_cache.py::test_expected_extensions_presentparametrize list accordingly.Test plan
pytest tests/gateway/test_document_cache.py(23 pass)pytest tests/gateway/test_telegram_documents.py(34 pass)