fix(gateway): pass model + runtime to BOOT.md startup hook#12514
Closed
C-fog wants to merge 1 commit into
Closed
Conversation
The boot-md hook created a bare AIAgent() with no model, provider,
api_key or base_url. The internal auto-resolve chain discards the
resolved model, causing every boot-md API call to fail with:
400 — 'model: The model code cannot be empty.'
Fix by passing the resolved model and runtime_kwargs through the
gateway:startup hook context, then forwarding them to AIAgent via
**runtime_kwargs — matching the pattern used by every other AIAgent
call site in the gateway.
Also move the gateway:startup emit to after channel directory build
so that hooks can safely use send_message during startup.
Refs: NousResearch#5239
Collaborator
|
Related to #5240 (same fix for BOOT.md startup hook auth bypass). Maintainers should pick one. |
This was referenced Apr 24, 2026
teknium1
added a commit
that referenced
this pull request
Apr 28, 2026
BOOT.md was merged in PR #3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (#5240, #12514, #14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes #5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
Contributor
|
Superseded by #17093 — we rolled BOOT.md back entirely rather than layering runtime-resolution fixes on top. The feature shipped in #3733 before it was ready (bare AIAgent() with no model/runtime, as you correctly identified), so pulling it is the right move for now. Thanks for the fix — if we bring BOOT.md back later, we'll do it with the runtime-resolution pattern you PR'd here. |
cluricaun28
referenced
this pull request
in cluricaun28/Logos
Apr 28, 2026
BOOT.md was merged in PR #3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (#5240, #12514, #14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes #5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
BOOT.md was merged in PR NousResearch#3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (NousResearch#5240, NousResearch#12514, NousResearch#14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes NousResearch#5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
donald131
pushed a commit
to donald131/hermes-agent
that referenced
this pull request
May 2, 2026
BOOT.md was merged in PR NousResearch#3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (NousResearch#5240, NousResearch#12514, NousResearch#14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes NousResearch#5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
BOOT.md was merged in PR NousResearch#3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (NousResearch#5240, NousResearch#12514, NousResearch#14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes NousResearch#5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
dannyJ848
pushed a commit
to dannyJ848/hermes-agent
that referenced
this pull request
May 17, 2026
BOOT.md was merged in PR NousResearch#3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (NousResearch#5240, NousResearch#12514, NousResearch#14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes NousResearch#5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
BOOT.md was merged in PR NousResearch#3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (NousResearch#5240, NousResearch#12514, NousResearch#14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes NousResearch#5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
BOOT.md was merged in PR NousResearch#3733 before the feature was ready — the built-in hook spawned a bare AIAgent() with no model/runtime kwargs, which immediately 401s on any provider with a custom endpoint. Three separate community PRs (NousResearch#5240, NousResearch#12514, NousResearch#14992) tried to paper over it. Remove the BOOT.md hook entirely and its user-facing docs/tips. Keep the gateway/builtin_hooks/ package and the HookRegistry._register_builtin_hooks() hook-point intact as the extension surface for future always-on gateway hooks. Closes NousResearch#5239. Co-authored-by: teknium1 <teknium@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
gateway:startuphook (boot_md.py) creates a bareAIAgent()without passingmodelor provider runtime kwargs. When using providers that require a model parameter (e.g. zai/GLM), this causes a400 model: The model code cannot be emptyerror. Every boot-md execution silently logs "nothing to report."Refs #5239
Root Cause
boot_md.py::_run_boot_agent()instantiatedAIAgent()with nomodelargument, defaulting toanthropic/claude-opus-4.6. For non-Anthropic providers, this either fails or uses the wrong model.Fix
Enrich the
gateway:startuphook context with the resolvedmodelname andruntime_kwargs, then extract and pass them toAIAgent()inboot_md.py.Changes
gateway/run.py(+27/-5):gateway:startupafter channel directory is built (so hooks can usesend_messagewith name resolution)_resolve_gateway_model()and runtime kwargs via_resolve_runtime_agent_kwargs()gateway/builtin_hooks/boot_md.py(+23/-3):modelandruntime_kwargsfrom hook context_run_boot_agent()→AIAgent(model=model, **runtime_kwargs, ...)Verification
Tested with zai/GLM provider — BOOT.md now successfully reads instructions, calls the LLM, and delivers the startup notification to Feishu:
Notes
boot_md(pre-existing code also lacked tests — difficult to unit-test due to AIAgent + gateway runtime dependency)runtime_kwargsmay containapi_keybut this is safe within the gateway process (same as all other AIAgent call sites)