feat(cli): strip markdown formatting from final replies#12262
Closed
lumenradley wants to merge 1 commit into
Closed
feat(cli): strip markdown formatting from final replies#12262lumenradley wants to merge 1 commit into
lumenradley wants to merge 1 commit into
Conversation
4fcc960 to
5a11329
Compare
teknium1
added a commit
that referenced
this pull request
Apr 20, 2026
…se panels Follow-up to #12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
teknium1
added a commit
that referenced
this pull request
Apr 20, 2026
…se panels Follow-up to #12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
teknium1
added a commit
that referenced
this pull request
Apr 20, 2026
…se panels Follow-up to #12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
Contributor
|
Merged via PR #12934 — your commit was cherry-picked onto current main with authorship preserved (see |
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
…se panels Follow-up to NousResearch#12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
…se panels Follow-up to NousResearch#12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
Luminet2023
pushed a commit
to Luminet2023/hermes-agent
that referenced
this pull request
May 1, 2026
…se panels Follow-up to NousResearch#12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…se panels Follow-up to NousResearch#12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…se panels Follow-up to NousResearch#12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…se panels Follow-up to NousResearch#12262 — extend final_response_markdown behavior to the other two final-response Panel render sites (background task completion and /btw responses) so users see consistent plain-text output everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves plain-text final reply rendering in the CLI by stripping common Markdown markers from model output while preserving useful structure like lists, checkboxes, blockquotes, and tables.
Related Issue
Fixes #TBD
Type of Change
Changes Made
cli.py.display.final_response_markdowninhermes_cli/config.py.tests/cli/test_cli_markdown_rendering.py.How to Test
source /Volumes/Shared/turbo/hermes-agent/venv/bin/activate && scripts/run_tests.sh.scripts/run_tests.sh tests/cli/test_cli_markdown_rendering.py -q.hermesand verify a Markdown-heavy final reply no longer prints markers like**and_in the default plain-text path while lists remain readable.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
feat/markdown-display-modes(5a11329a778a):29 failed, 12923 passed, 38 skipped.upstream/mainbaseline on this machine:34 failed, 12909 passed, 38 skipped.