chore: enforce LF line endings for container entrypoints#12181
Merged
benbarclay merged 1 commit intoJun 4, 2026
Conversation
Windows contributors checking out on NTFS with git's default core.autocrlf will end up with CRLF in docker/entrypoint.sh. When COPY'd into the image and invoked as ENTRYPOINT, the kernel interprets the trailing \r as part of the interpreter path, producing a confusing 'no such file or directory' despite the file being present and executable. Lock LF for the usual suspects (*.sh, Dockerfile, *.dockerfile, and the specific docker/entrypoint.sh). The existing tree is already LF; this is preventive against future Windows regressions only.
bluefishs
added a commit
to bluefishs/hermes-agent
that referenced
this pull request
Apr 24, 2026
- docs/plans/upstream-sync-cadence.md: per-release-tag sync rhythm (replacing monthly), check command, conflict handling, escalation - docs/plans/upstream-feature-eval-2026-04-18.md: evaluate /steer (adopt), execute_code project/strict (default accept, re-eval with ADR-0017), Tool Gateway (decline) - docs/plans/upstream-pr-web-build.md: PR draft and checklist used to submit NousResearch#12180 and NousResearch#12181
davidgut1982
pushed a commit
to davidgut1982/hermes-agent
that referenced
this pull request
Jun 5, 2026
…h#12181) Windows contributors checking out on NTFS with git's default core.autocrlf will end up with CRLF in docker/entrypoint.sh. When COPY'd into the image and invoked as ENTRYPOINT, the kernel interprets the trailing \r as part of the interpreter path, producing a confusing 'no such file or directory' despite the file being present and executable. Lock LF for the usual suspects (*.sh, Dockerfile, *.dockerfile, and the specific docker/entrypoint.sh). The existing tree is already LF; this is preventive against future Windows regressions only.
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
…h#12181) Windows contributors checking out on NTFS with git's default core.autocrlf will end up with CRLF in docker/entrypoint.sh. When COPY'd into the image and invoked as ENTRYPOINT, the kernel interprets the trailing \r as part of the interpreter path, producing a confusing 'no such file or directory' despite the file being present and executable. Lock LF for the usual suspects (*.sh, Dockerfile, *.dockerfile, and the specific docker/entrypoint.sh). The existing tree is already LF; this is preventive against future Windows regressions only.
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
Windows contributors checking out on NTFS with git's default core.autocrlf will end up with CRLF in docker/entrypoint.sh. When COPY'd into the image and invoked as ENTRYPOINT, the kernel interprets the trailing \r as part of the interpreter path, producing a confusing 'no such file or directory' despite the file being present and executable. Lock LF for the usual suspects (*.sh, Dockerfile, *.dockerfile, and the specific docker/entrypoint.sh). The existing tree is already LF; this is preventive against future Windows regressions only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
.gitattributesrule that locks LF line endings for shell scripts, theDockerfile, anddocker/entrypoint.sh.Preventive, not corrective. The tree at
v2026.4.16is already LF — this change only takes effect if a contributor on Windows (withcore.autocrlf=true, the Git-for-Windows default) touches these files in a future PR and git would otherwise convert them to CRLF on checkout.Related Issue
None — this is a forward-looking hardening PR with no current user-visible bug. Happy to close if maintainers would rather address only on a repro.
Type of Change
Changes Made
.gitattributes: addtext eol=lfrules for*.sh,Dockerfile,*.dockerfile, and the specificdocker/entrypoint.sh.How to Test
On a Windows host with
core.autocrlf=true(Git for Windows default):The failure mode this prevents: COPYing a CRLF-ended
docker/entrypoint.shinto a Linux image yieldsENTRYPOINTerrors like/opt/hermes/docker/entrypoint.sh: not foundbecause the kernel treats the trailing\ras part of the interpreter path.Checklist
Code
chore: ...).gitattributeshardening PR..gitattributesedit).pytest tests/ -qnot run —.gitattributesdoes not affect any Python code path.Cross-platform