fix(anthropic): skip thinking params for Haiku models#1130
Merged
Conversation
Haiku models don't support extended thinking at all. Without this guard, claude-haiku-4-5-20251001 would receive type=enabled + budget_tokens and return a 400 error. Incorporates the fix from PR #1127 (by frizynn) on top of #1128's adaptive thinking refactor. Verified live with Claude Code OAuth: claude-opus-4-6 → adaptive thinking ✓ claude-haiku-4-5 → no thinking params ✓ claude-sonnet-4 → enabled thinking ✓
3 tasks
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…c877bdeb fix(anthropic): skip thinking params for Haiku models
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…c877bdeb fix(anthropic): skip thinking params for Haiku models
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…c877bdeb fix(anthropic): skip thinking params for Haiku models
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…c877bdeb fix(anthropic): skip thinking params for Haiku models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haiku models don't support extended thinking. Without this guard,
claude-haiku-4-5-20251001getsthinking: {type: enabled, budget_tokens: ...}and returns 400.Adds
"haiku" not in model.lower()guard on top of #1128's adaptive thinking refactor. Incorporates the fix from PR #1127 by @frizynn.Verified live:
claude-opus-4-6→ adaptive thinking ✓claude-haiku-4-5-20251001→ no thinking params ✓claude-sonnet-4-20250514→ enabled thinking ✓