chore(skills): clean up PR #862 + feat(docs): add search to Docusaurus#1053
Merged
Conversation
Follow-up to PR #862 (local skills classification by arceus77-7): - Remove unnecessary isinstance guard on _read_manifest() return value — it always returns Dict[str, str], so set() on it suffices. - Extract repeated hub-dir monkeypatching into a shared pytest fixture (hub_env). - Add three_source_env fixture for source-classification tests. - Add _read_manifest monkeypatch to test_do_list_initializes_hub_dir (was fragile — relied on empty skills list masking the real manifest). - Add test coverage for --source hub and --source builtin filters. - Extract _capture() helper to reduce console/StringIO boilerplate. 5 tests, all green.
Add @easyops-cn/docusaurus-search-local (v0.55.1) for offline/local full-text search across all documentation pages. - Search bar appears in the navbar (Ctrl/Cmd+K shortcut) - Builds a search index at build time — no external service needed - Highlights matched terms on target page after clicking a result - Dedicated /search page for expanded results - Blog indexing disabled (blog is off) - docsRouteBasePath set to '/' to match existing docs routing
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…c877bdeb chore(skills): clean up PR NousResearch#862 + feat(docs): add search to Docusaurus
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…c877bdeb chore(skills): clean up PR NousResearch#862 + feat(docs): add search to Docusaurus
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…c877bdeb chore(skills): clean up PR NousResearch#862 + feat(docs): add search to Docusaurus
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…c877bdeb chore(skills): clean up PR NousResearch#862 + feat(docs): add search to Docusaurus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Skills cleanup (follow-up to PR #862 by @arceus77-7)
hermes_cli/skills_hub.py:isinstance(bundled_manifest, dict)guard —_read_manifest()always returnsDict[str, str], soset(_read_manifest())suffices.tests/hermes_cli/test_skills_hub.py:hub_envpytest fixture.three_source_envfixture for source-classification tests._read_manifestmonkeypatch totest_do_list_initializes_hub_dir(previously fragile).--source huband--source builtinfilters._capture()helper to reduce boilerplate.2. Docusaurus search
Adds
@easyops-cn/docusaurus-search-local(v0.55.1) for offline full-text search:/searchpage for expanded resultsdocsRouteBasePath: '/')Test plan