Skip to content

fix: resolve delegation providers from custom_providers#1012

Closed
stablegenius49 wants to merge 1 commit into
NousResearch:mainfrom
stablegenius49:pr-factory/issue-1011-custom-delegation
Closed

fix: resolve delegation providers from custom_providers#1012
stablegenius49 wants to merge 1 commit into
NousResearch:mainfrom
stablegenius49:pr-factory/issue-1011-custom-delegation

Conversation

@stablegenius49

@stablegenius49 stablegenius49 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve named custom providers from config.yaml custom_providers during runtime provider selection
  • allow delegation config to reference either the raw custom provider name (for example "local") or the menu-key form ("custom:local")
  • add regression coverage for saved custom-provider credentials and env-key fallback

Testing

  • python3 -m pytest -q -o addopts='' tests/test_runtime_provider_resolution.py
  • python3 -m pytest -q -o addopts='' tests/test_api_key_providers.py::TestRuntimeProviderResolution

Closes #1011.

teknium1 added a commit that referenced this pull request Mar 14, 2026
Follow up on salvaged PR #1012.
Prevents raw custom-provider names from intercepting built-in provider ids,
and keeps the regression coverage focused on current-main behavior.
teknium1 added a commit that referenced this pull request Mar 14, 2026
Salvaged PR #1012 onto current main with the contributor commit preserved plus a small follow-up for builtin-provider shadowing and stale test cleanup.
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #1328. Your substantive runtime-provider fix was cherry-picked onto current main with authorship preserved, plus a small follow-up for builtin-provider shadowing and stale test cleanup. Thanks for the contribution.

@teknium1 teknium1 closed this Mar 14, 2026
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
Follow up on salvaged PR NousResearch#1012.
Prevents raw custom-provider names from intercepting built-in provider ids,
and keeps the regression coverage focused on current-main behavior.
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…ec1096a3

Salvaged PR NousResearch#1012 onto current main with the contributor commit preserved plus a small follow-up for builtin-provider shadowing and stale test cleanup.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
Follow up on salvaged PR NousResearch#1012.
Prevents raw custom-provider names from intercepting built-in provider ids,
and keeps the regression coverage focused on current-main behavior.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…ec1096a3

Salvaged PR NousResearch#1012 onto current main with the contributor commit preserved plus a small follow-up for builtin-provider shadowing and stale test cleanup.
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
Follow up on salvaged PR NousResearch#1012.
Prevents raw custom-provider names from intercepting built-in provider ids,
and keeps the regression coverage focused on current-main behavior.
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
…ec1096a3

Salvaged PR NousResearch#1012 onto current main with the contributor commit preserved plus a small follow-up for builtin-provider shadowing and stale test cleanup.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
Follow up on salvaged PR NousResearch#1012.
Prevents raw custom-provider names from intercepting built-in provider ids,
and keeps the regression coverage focused on current-main behavior.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…ec1096a3

Salvaged PR NousResearch#1012 onto current main with the contributor commit preserved plus a small follow-up for builtin-provider shadowing and stale test cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: agent delegation to custom inference provider does not work

3 participants