fix(dingtalk): close session websocket on disconnect#10070
Closed
Asunfly wants to merge 1 commit into
Closed
Conversation
teknium1
added a commit
that referenced
this pull request
Apr 17, 2026
teknium1
added a commit
that referenced
this pull request
Apr 17, 2026
Contributor
|
Merged via #11556 (#11556). Your commit was cherry-picked with authorship preserved in git log (7c932c5). Thanks for the tight, well-tested fix — the systemd stop-sigterm hang was affecting anyone running DingTalk under |
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disconnect()Why
In local verification on WSL,
hermes-gateway.servicecould get stuck instop-sigtermand be SIGKILLed during restart while DingTalk was configured. Closing the SDK websocket explicitly gives the stream loop a clean shutdown path instead of waiting for the remote side to time out.This PR is intentionally scoped to shutdown behavior only. Existing open DingTalk PRs already cover CallbackMessage parsing, async SDK compatibility, and
oapi.dingtalk.comwebhook routing.Related: #7562
Test plan
pytest tests/gateway/test_dingtalk.py::TestConnect::test_disconnect_closes_session_websocket -vpytest tests/gateway/test_dingtalk.py -qsystemctl --user restart hermes-gatewayno longer hangs in the idle DingTalk case after applying the patch