fix: normalize tool_call_id whitespace in sanitizer#10039
Open
nightq wants to merge 1 commit into
Open
Conversation
Fixes NousResearch#9999 Root cause: _sanitize_api_messages compared raw tool_call_id strings without stripping whitespace, causing valid tool results to be treated as orphaned when IDs had leading/trailing spaces. Fix: strip whitespace in _get_tool_call_id_static and when collecting result_call_ids from tool messages.
Collaborator
|
Likely duplicate of #10000 — same fix: normalize tool_call_id whitespace in run_agent sanitizer to prevent orphaned tool results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tool result misclassification when tool_call_id has leading/trailing whitespace.
Root Cause
_sanitize_api_messages()compared raw tool_call_id strings without stripping whitespace. When assistant-side IDs (via_get_tool_call_id_static) and tool-result IDs diverged due to surrounding whitespace, valid tool results were treated as orphaned and replaced with stub placeholders.Fix
_get_tool_call_id_static()for both dict and object tool_callsresult_call_idsfrom tool messagesTest Plan
Closes #9999