fix(run-agent): normalize tool_call_id before matching results#10000
Open
shm197 wants to merge 1 commit into
Open
fix(run-agent): normalize tool_call_id before matching results#10000shm197 wants to merge 1 commit into
shm197 wants to merge 1 commit into
Conversation
2 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a
run_agent.pybug where Hermes can replace a real tool result with[Result unavailable — see context summary above]if the persistedtool_call_idhas surrounding whitespace.The root cause is inconsistent normalization:
_build_assistant_message()_sanitize_api_messages()was still comparing raw tool-resulttool_call_idvaluesThat makes these two IDs fail to match even though they are semantically the same:
functions.cronjob:24functions.cronjob:24This PR normalizes
tool_call_idvalues before comparing them during the pre-call sanitizer pass.Related Issue
Fixes #9999
Type of Change
Changes Made
run_agent.pyAIAgent._normalize_tool_call_id()_get_tool_call_id_static()result_call_idstests/run_agent/test_run_agent.pytool_call_idhas leading whitespacetool_call_idhas surrounding whitespace_build_assistant_message()trims tool call IDsHow to Test
functions.cronjob:24functions.cronjob:24and verify Hermes no longer injects the
Result unavailablestub for that pair.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passuvDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Targeted verification:
Local full-suite run status:
The full
pytest tests/ -qrun does not currently pass in my local environment, so that checklist item is intentionally left unchecked.