Skip to content

Remove OneConfig compat layer #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NopoTheGamer merged 2 commits into from
Jan 4, 2025
Merged

Remove OneConfig compat layer #1415

NopoTheGamer merged 2 commits into from
Jan 4, 2025

Conversation

@Wyvest
Copy link
Contributor

@Wyvest Wyvest commented Dec 19, 2024 •
edited
Loading

The OneConfig compat layer is not complete and has various desync issues. It has to be rewritten for OneConfig V1 anyways, and once that happens nea has stated she would like it in MoulConfig altogether so that other mods like SkyHanni can support it. This should be removed in the meantime.

@jani270
Copy link
Collaborator

jani270 commented Dec 19, 2024

Clueless surely it will happen

@lineargraph
Copy link
Member

lineargraph commented Dec 28, 2024 •
edited
Loading

nea has stated they would like it in MoulConfig altogether

I would just like to interject and mention that "they" is not one of my pronouns.

Also we do have a buildflag for this already, we could just disable that buildflag if this causes issues.

@Wyvest
Copy link
Contributor Author

Wyvest commented Dec 28, 2024

I would just like to interject and mention that "they" is not one of my pronouns.

Fixed, apologies

Also we do have a buildflag for this already, we could just disable that buildflag if this causes issues.

Isn't it defaulted to false?

NopoTheGamer
NopoTheGamer reviewed Dec 28, 2024
View reviewed changes
@lineargraph
Copy link
Member

lineargraph commented Dec 29, 2024

Also we do have a buildflag for this already, we could just disable that buildflag if this causes issues.

Isn't it defaulted to false?

It just changes whether NEU loads oneconfig itself, or if it only hooks into existing oneconfig installations, which is why i crossed out that line.

@NopoTheGamer NopoTheGamer merged commit ceb6788 into NotEnoughUpdates:master Jan 4, 2025
6 checks passed
Nessiesson pushed a commit to Nessiesson/NotEnoughUpdates that referenced this pull request Jan 24, 2025
@Wyvest @Nessiesson
Remove OneConfig compat layer (NotEnoughUpdates#1415)
ec97238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NopoTheGamer NopoTheGamer NopoTheGamer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wyvest @jani270 @lineargraph @NopoTheGamer