Skip to content

Add NeuCalendar improvements #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lineargraph merged 6 commits into from
Jun 12, 2024
Merged

Add NeuCalendar improvements #1204

lineargraph merged 6 commits into from
Jun 12, 2024

Conversation

@NopoTheGamer
Copy link
Member

@NopoTheGamer NopoTheGamer commented Jun 6, 2024 •
edited
Loading

  • fixes being able to open calendar GUI in the storage overlay
  • shows Oringo's leg pet in the calendar
  • fixes the regex being broken for late months for jacob
  • fixes the jacob contests not being tracked if you have the new talisman

@NopoTheGamer NopoTheGamer linked an issue Jun 6, 2024 that may be closed by this pull request
StorageOverlay: neucalendar pops up when clicking on a storage page at the top of your screen #931
Closed
@NopoTheGamer NopoTheGamer changed the title Fix Being able to open calendar gui in the storage overlay Add NeuCalendar improvements Jun 6, 2024
@NopoTheGamer NopoTheGamer linked an issue Jun 6, 2024 that may be closed by this pull request
NEUCalendar: Add next legy pet to traveling zoo lore #852
Closed
jani270
jani270 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

lineargraph
lineargraph approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@lineargraph lineargraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should really replace that ableToClickCalendar variable with something less stateful.

@lineargraph lineargraph merged commit fc45d59 into master Jun 12, 2024
@lineargraph lineargraph deleted the calendar branch June 12, 2024 16:38
heinrich26 pushed a commit to heinrich26/NotEnoughUpdates that referenced this pull request Jun 29, 2024
@NopoTheGamer @heinrich26
Add NeuCalendar improvements (NotEnoughUpdates#1204)
aa9c8d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lineargraph lineargraph lineargraph approved these changes

@jani270 jani270 jani270 approved these changes

@Lulonaut Lulonaut Awaiting requested review from Lulonaut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StorageOverlay: neucalendar pops up when clicking on a storage page at the top of your screen NEUCalendar: Add next legy pet to traveling zoo lore

4 participants

@NopoTheGamer @lineargraph @jani270