meta: Fix /neupronouns output to condense to a single line #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironm00n
approved these changes
May 13, 2024
heinrich26
pushed a commit
to heinrich26/NotEnoughUpdates
that referenced
this pull request
Jun 29, 2024
…Updates#1170) Improve /neupronouns output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
/neupronouns <user>will display the following output:This implementation is... fine. It gets the job done, albeit in an unorthodox way. The issue with having every character be proceeded by a newline is that if you use a mod/client that condenses chat messages, such as Patcher, the output can look confusing to downright illegible.
Instead, a much more logical solution would be to place the pronouns on a single chat message, fixing the compacted chat issue and saving some brainpower from piecing together each character.