Add /neucheck command & check for enchant parsers #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NopoTheGamer
requested changes
May 14, 2024
src/main/kotlin/io/github/moulberry/notenoughupdates/miscfeatures/checks/EnchantsCheck.kt
Outdated
Show resolved
Hide resolved
NopoTheGamer
requested changes
May 14, 2024
src/main/kotlin/io/github/moulberry/notenoughupdates/miscfeatures/checks/EnchantsCheck.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/github/moulberry/notenoughupdates/miscfeatures/checks/EnchantsCheck.kt
Outdated
Show resolved
Hide resolved
NopoTheGamer
approved these changes
May 28, 2024
Lulonaut
approved these changes
May 31, 2024
heinrich26
pushed a commit
to heinrich26/NotEnoughUpdates
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an /neucheck command boilerplate so we can notify user about incompatibilities with other mods. It mainly servers to reduce headaches in neu-support (we need jani to keep his sanity).
Also already implements /neucheck neuec that returns which mods are loaded and how to disable the enchant parsing in them.
This can be obviously modified to check for the actual setting if parsing is enabled & set it to the correct value.
But i am bad at kotlin reflections and I will have close to no free time next week so just wanted to push this out...