Skip to content

Conversation

@MisterCheezeCake
Copy link
Member

Hypixel added XP discounts for enchanting and adding books in Febuary and the Enchant/Hex GUIs have been slightly broken ever since, since they don't have the code to parse discounts. I could not fix the xp costs in the list being incorrect, since the information about discounts is not available to us before the user clicks on an enchant (theoretically possible with API but that's a problem for another day).

I made it so every time an Enchantment class is instantiated, there is now a check to see if a discount exists and if so, the cost information is overridden with the discount info. This makes it so the cost information displayed on the enchant specific page is accurate, and fixes the problem of a greyed out "Apply" button when the player is able to apply the enchant.

@jani270 jani270 added the bug-fix This PR fixes a bug label May 10, 2024
@jani270 jani270 merged commit 4776b0d into NotEnoughUpdates:master May 11, 2024
heinrich26 pushed a commit to heinrich26/NotEnoughUpdates that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants