Skip to content

Conversation

@Wyvest
Copy link
Contributor

@Wyvest Wyvest commented Apr 29, 2024

No description provided.

@jani270 jani270 requested a review from lineargraph April 29, 2024 07:49
@NopoTheGamer
Copy link
Member

I got someone to test and they say it works!

image

@lineargraph
Copy link
Member

I mean it works, and it is somehow even worse code than the rest of this compat layer, so why not

@Wyvest
Copy link
Contributor Author

Wyvest commented Apr 29, 2024

I mean it works, and it is somehow even worse code than the rest of this compat layer, so why not

I am pretty aware it is terrible code but it's going to be rewritten with OneConfig V1 anyways and it's a pretty critical error (the compat layer literally does not function)

For future reference: does Property work on all option types? Does Property just support any type in it? Currently it only supports dropdowns.

@lineargraph
Copy link
Member

@Wyvest
Copy link
Contributor Author

Wyvest commented Apr 29, 2024

MoulConfig supports Property<T> instead of T transparently for all editors: NotEnoughUpdates/MoulConfig@64d7fe2/common/src/main/java/io/github/notenoughupdates/moulconfig/processor/ProcessedOption.java#L56-L67

ah. well oneconfig is a bit brittle code-wise and it would be a bit of a pain to support this (i think i would have to make a property wrapper for every config option and i don't want to do that), so ill wait till V1 for that.

For now, though, this PR should be merged as the compat layer just doesn't function rn

@lineargraph
Copy link
Member

so ill wait till V1 for that.

Pretty sure i got told like at least a year ago that oneconfig would make those kinds of things easier soon, so i would rather still get it right in the current system. I will rewrite the entire thing myself anyway to be not neu exclusive.

@lineargraph lineargraph merged commit 585b29b into NotEnoughUpdates:master May 2, 2024
@lineargraph lineargraph changed the title Add support for Property option for dropdown Add support for Property option for dropdown in oneconfig May 2, 2024
heinrich26 pushed a commit to heinrich26/NotEnoughUpdates that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants