Skip to content

Fix Mining Overlay showing when swapping worlds #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThatGravyBoat merged 1 commit into from
Apr 23, 2024
Merged

Fix Mining Overlay showing when swapping worlds #1107

ThatGravyBoat merged 1 commit into from
Apr 23, 2024

Conversation

@NopoTheGamer
Copy link
Member

@NopoTheGamer NopoTheGamer commented Apr 20, 2024

people would of complained if left unfixed

@NopoTheGamer NopoTheGamer added the bug-fix This PR fixes a bug label Apr 23, 2024
@ThatGravyBoat ThatGravyBoat merged commit 80cec76 into master Apr 23, 2024
@ThatGravyBoat ThatGravyBoat deleted the Still-dont-think-its-that-big-of-deal-that-it-needs-to-be-fixed-in-this-version branch April 23, 2024 06:11
@Fix3dll
Copy link

Fix3dll commented Apr 23, 2024 •
edited
Loading

@NopoTheGamer Its fired when you entering crystal hollows while forge widget closed.

[12:48:29] [Client thread/INFO]: [CHAT] §r§7Warping...§r
[12:48:29] [Client thread/INFO]: [CHAT] §7Sending to server mini19CT...§r
[12:48:31] [Client thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.fml.common.gameevent.TickEvent$ClientTickEvent@24b5021:
java.lang.NullPointerException
	at io.github.moulberry.notenoughupdates.overlays.MiningOverlay.getTabLinesOrAddWarning(MiningOverlay.java:566) ~[MiningOverlay.class:?]
	at io.github.moulberry.notenoughupdates.overlays.MiningOverlay.update(MiningOverlay.java:302) ~[MiningOverlay.class:?]
	at io.github.moulberry.notenoughupdates.overlays.TextTabOverlay.realTick(TextTabOverlay.java:64) ~[TextTabOverlay.class:?]
	at io.github.moulberry.notenoughupdates.listener.NEUEventListener.onTick(NEUEventListener.java:159) ~[NEUEventListener.class:?]

heinrich26 pushed a commit to heinrich26/NotEnoughUpdates that referenced this pull request Jun 29, 2024
@NopoTheGamer @heinrich26
Fix Mining Overlay showing when swapping worlds (NotEnoughUpdates#1107)
9a2fee1 
Fixed mining overlay showing when swapping worlds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThatGravyBoat ThatGravyBoat ThatGravyBoat approved these changes

@Lulonaut Lulonaut Lulonaut approved these changes

@lineargraph lineargraph Awaiting requested review from lineargraph

@jani270 jani270 Awaiting requested review from jani270

Assignees

No one assigned

Labels

bug-fix This PR fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NopoTheGamer @Fix3dll @ThatGravyBoat @Lulonaut