allow call options as a post-fix expression#853
Closed
OmarTawfik wants to merge 1 commit intoNomicFoundation:mainfrom
Closed
allow call options as a post-fix expression#853OmarTawfik wants to merge 1 commit intoNomicFoundation:mainfrom
OmarTawfik wants to merge 1 commit intoNomicFoundation:mainfrom
Conversation
This allows stand-alone call options, without trailing arguments, which is legal:
```solidity
msg.sender.call{value: msg.value-amountEth};
```
Fixes NomicFoundation#850
🦋 Changeset detectedLatest commit: d16c874 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
OmarTawfik
commented
Feb 24, 2024
| Error: Expected Identifier. | ||
| ╭─[crates/solidity/testing/snapshots/cst_output/TryStatement/try_catch/input.sol:1:12] | ||
| │ | ||
| 1 │ try a.b() {} catch {} |
Contributor
Author
There was a problem hiding this comment.
even though a NamedArgument is required inside {}, it is matched successfully as a post-fix expression, and thus, failing for expecting the try body afterwards.
Contributor
Author
|
Converting to draft until #862 is ready. |
auto-merge was automatically disabled
February 28, 2024 07:56
Pull request was converted to draft
Contributor
Author
|
Closing in favor of #862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows stand-alone call options, without trailing arguments, which is legal:
Fixes #850