Use an enum for the CST nodes instead of a string#713
Merged
Xanewok merged 5 commits intoNomicFoundation:mainfrom Jan 3, 2024
Merged
Use an enum for the CST nodes instead of a string#713Xanewok merged 5 commits intoNomicFoundation:mainfrom
Xanewok merged 5 commits intoNomicFoundation:mainfrom
Conversation
|
Merged
94885ef to
082e752
Compare
OmarTawfik
reviewed
Dec 20, 2023
OmarTawfik
reviewed
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #703
Builds on and should be merged after #710
Separated it out since it probably should warrant another review pass and is mostly an optimization.