chore: Run smoke test suite in --release mode#592
Merged
AntonyBlakey merged 2 commits intoNomicFoundation:mainfrom Sep 15, 2023
Merged
chore: Run smoke test suite in --release mode#592AntonyBlakey merged 2 commits intoNomicFoundation:mainfrom
AntonyBlakey merged 2 commits intoNomicFoundation:mainfrom
Conversation
This cuts down from ETA 3-5 hours down ETA ~15 minutes on the sanctuary-arbitrum dataset on Ryzen 3900X
|
Xanewok
added a commit
to Xanewok/slang
that referenced
this pull request
Sep 6, 2023
This reverts commit 6bad240. Separated this into NomicFoundation#592.
OmarTawfik
reviewed
Sep 8, 2023
|
|
||
| return Command::new("cargo") | ||
| .arg("run") | ||
| .arg(if self.command == RunCommand::SolidityTestingSmoke { |
Contributor
There was a problem hiding this comment.
nit: not sure if an empty string arg is absorbed/displayed properly. I suggest conditionally adding it:
let mut command = Command::new("cargo").arg("run");
if self.command == RunCommand::SolidityTestingSmoke {
command = command.flag("--release");
}
return command.arg(....rest....).run();
OmarTawfik
reviewed
Sep 8, 2023
Contributor
OmarTawfik
left a comment
There was a problem hiding this comment.
Great catch! left one suggestion.
AntonyBlakey
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cuts down from ETA 3-5 hours down ETA ~15 minutes on the sanctuary-arbitrum dataset on Ryzen 3900X