fix reservation of keywords added in 0.8.24#1097
Merged
OmarTawfik merged 1 commit intoNomicFoundation:mainfrom Sep 18, 2024
Merged
fix reservation of keywords added in 0.8.24#1097OmarTawfik merged 1 commit intoNomicFoundation:mainfrom
0.8.24#1097OmarTawfik merged 1 commit intoNomicFoundation:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 18a84f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4ebc6c1 to
4ca9e52
Compare
They were actually reserved in `0.8.25`.
4ca9e52 to
18a84f5
Compare
Xanewok
approved these changes
Sep 18, 2024
Contributor
Xanewok
left a comment
There was a problem hiding this comment.
Looking at argotorg/solidity@a388ccb which introduced the error and it looks like it's another change that's EVM target-specific, i.e. in Cancun it strictly errors out but for older versions like Shanghai it should keep working (but still using 0.8.25).
I'm happy with landing this to be consistent with how we handle other built-ins but maybe we'd need to discuss how we want to approach this in the long run at some point (e.g. accept as an Identifier and have a EVM target-specific validation pass later on @AntonyBlakey).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@0.18.0 ### Minor Changes - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - migrate NAPI front-end to WASM and ESM - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `TerminalKindExtensions.is_valid()` API to distinguish correctly-parsed and erroneous nodes - [#1117](#1117) [`be7bb79`](be7bb79) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename `Language` API to `Parser`, in preparation for introducing a multi-file compilation API. - [#1116](#1116) [`c88f9b5`](c88f9b5) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - merge `language`, `parse_error`, `parse_output` namespaces into the `parser` namespace. - [#1115](#1115) [`96df645`](96df645) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - merge `cursor`, `kinds`, `query`, and `text_index` namespaces into the `cst` namespace. - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - unify API methods on `TerminalNode` and `NonTerminalNode`, and add type assertions and guards to both types - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - expose edges and edge labels on CST nodes via `Node.children()` method. This allows distinguishing between children of the same node based on their label/role in the parent, even if they have the same kind. - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `TerminalNode.id` and `Nonterminal.id` properties to get a numeric ID that can be used in indexing/comparison at runtime. - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `TerminalKindExtensions.is_trivia()` API to distinguish between trivia nodes and other contentful nodes ### Patch Changes - [#1096](#1096) [`15c437c`](15c437c) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for Solidity `0.8.27`. - [#1120](#1120) [`25eef3e`](25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - change `Parser::new()` constructor to `Parser::create()` static method. - [#1097](#1097) [`e17af22`](e17af22) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Fix the grammar of keywords (`blobbasefee`, `blobhash`, `mcopy`, `tload`, `tstore`) added in `0.8.24`, as they were actually reserved in `0.8.25`. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rollup-smithbm0p
added a commit
to rollup-smithbm0p/slang
that referenced
this pull request
Dec 26, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@0.18.0 ### Minor Changes - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - migrate NAPI front-end to WASM and ESM - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `TerminalKindExtensions.is_valid()` API to distinguish correctly-parsed and erroneous nodes - [#1117](NomicFoundation/slang#1117) [`be7bb79`](NomicFoundation/slang@be7bb79) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename `Language` API to `Parser`, in preparation for introducing a multi-file compilation API. - [#1116](NomicFoundation/slang#1116) [`c88f9b5`](NomicFoundation/slang@c88f9b5) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - merge `language`, `parse_error`, `parse_output` namespaces into the `parser` namespace. - [#1115](NomicFoundation/slang#1115) [`96df645`](NomicFoundation/slang@96df645) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - merge `cursor`, `kinds`, `query`, and `text_index` namespaces into the `cst` namespace. - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - unify API methods on `TerminalNode` and `NonTerminalNode`, and add type assertions and guards to both types - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - expose edges and edge labels on CST nodes via `Node.children()` method. This allows distinguishing between children of the same node based on their label/role in the parent, even if they have the same kind. - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `TerminalNode.id` and `Nonterminal.id` properties to get a numeric ID that can be used in indexing/comparison at runtime. - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `TerminalKindExtensions.is_trivia()` API to distinguish between trivia nodes and other contentful nodes ### Patch Changes - [#1096](NomicFoundation/slang#1096) [`15c437c`](NomicFoundation/slang@15c437c) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for Solidity `0.8.27`. - [#1120](NomicFoundation/slang#1120) [`25eef3e`](NomicFoundation/slang@25eef3e) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - change `Parser::new()` constructor to `Parser::create()` static method. - [#1097](NomicFoundation/slang#1097) [`e17af22`](NomicFoundation/slang@e17af22) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Fix the grammar of keywords (`blobbasefee`, `blobhash`, `mcopy`, `tload`, `tstore`) added in `0.8.24`, as they were actually reserved in `0.8.25`. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were actually reserved in
0.8.25.