nixos/python-test-driver: add option to disable the linter without warning#96515
Closed
khumba wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/python-test-driver: add option to disable the linter without warning#96515khumba wants to merge 1 commit intoNixOS:masterfrom
khumba wants to merge 1 commit intoNixOS:masterfrom
Conversation
…rning This follows up from nixpkgs#76171 to add a way to disable the linter for NixOS tests using the Python driver, without printing a warning to the console, as `skipLint` does. Linting is skipped if either `skipLint` or the new `skipLintSilently` option are true, but a warning about skipping is only printed if `skipLintSilently` is false. This is meant to allow running tests during development, or outside of Nixpkgs, without forcing unnecessary work to conform to a style guide when it's not relevant.
10 tasks
Contributor
I would agree with that |
Contributor
Author
|
Closing as this isn't needed, Black already offers a way with |
Member
|
Can you add a small reference to it in the manual? (Maybe add this is for non-nixpkgs usages)
|
Contributor
Author
|
Yes, that's a good suggestion! Will do.
…On September 3, 2020 10:46:36 p.m. PDT, Florian Klink ***@***.***> wrote:
Can you add a small reference to it in the manual? (Maybe add this is
for non-nixpkgs usages)
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#96515 (comment)
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is to partially address #72964.
This follows up from #76171 to add a way to disable the linter for
NixOS tests using the Python driver, without printing a warning to the
console, as
skipLintdoes. Linting is skipped if eitherskipLintorthe new
skipLintSilentlyoption are true, but a warning about skippingis only printed if
skipLintSilentlyis false.This is meant to allow running tests during development, or outside of
Nixpkgs, without forcing unnecessary work to conform to a style guide
when it's not relevant.
skipLintSilentlyis not meant to be used for merged to Nixpkgs main,non-feature branches.
I'm open to combining these two parameters or having some other way
to pass them in, I more just want a way to turn off a stream of
messages I see when building a bunch of tests with linting disabled.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)