nixos/python-test-driver: add an option to disable python linter#76171
nixos/python-test-driver: add an option to disable python linter#76171worldofpeace merged 1 commit intoNixOS:masterfrom
Conversation
|
We should pipe this through a warn somehow if that option is set, so it's really noticeable it should not be PRed as-is.
|
While it's a good idea to automate the linting of the python code used for our tests, I think that it can be quite distracting when hacking on a NixOS test. I figured that it might be more convenient to add an option as a shortcut for this to avoid that everyone needs to dig into the test driver again.
f75a7ee to
b726617
Compare
|
This would make me a bit happier ref #72964. I still think linting when the values are in nix strings not as great. |
Tbh I fully agree! This is more or less the middle-ground-solution. I thought that there are probably good reasons to use some linting, but I think that there's no point to use this when actively working on a test. As this is IMHO an improvement over the current situation - is there anything that keeps this from merging? :) |
It's a nice middle-ground improvement. Though, it's a bit funny. Our testing function has an argument to disable a linter, it's unexpected. That being said, I'm going to merge it 😄 |
worldofpeace
left a comment
There was a problem hiding this comment.
Things tested:
Built and read NixOS manual ✔️
Ran a test with skipLint and saw a warning ✔️
Motivation for this change
While it's a good idea to automate the linting of the python code used
for our tests, I think that it can be quite distracting when hacking on
a NixOS test.
I figured that it might be more convenient to add an option as a
shortcut for this to avoid that everyone needs to dig into the test
driver again.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @