Skip to content

vala: 0.48.1 -> 0.48.7#92592

Merged
worldofpeace merged 1 commit intoNixOS:stagingfrom
worldofpeace:vala-update
Jul 7, 2020
Merged

vala: 0.48.1 -> 0.48.7#92592
worldofpeace merged 1 commit intoNixOS:stagingfrom
worldofpeace:vala-update

Conversation

@worldofpeace
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace commented Jul 7, 2020

https://gitlab.gnome.org/GNOME/vala/-/blob/0.48.7/NEWS

Motivation for this change

I needed this to update elementary-files and have to succeed to build https://github.com/elementary/files/releases/tag/4.4.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested review from hedning and jtojnar July 7, 2020 15:19
@worldofpeace worldofpeace mentioned this pull request Jul 7, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from peterhoeg July 7, 2020 15:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 7, 2020
jonringer
jonringer approved these changes Jul 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

no testing

jtojnar
jtojnar approved these changes Jul 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not see anything problematic in the change log.

@worldofpeace worldofpeace merged commit 71d6910 into NixOS:staging Jul 7, 2020
@worldofpeace worldofpeace deleted the vala-update branch July 7, 2020 20:53
vcunat added a commit that referenced this pull request Jul 26, 2020
@vcunat
pantheon.gala: fix build by using older vala
b49e798 
The build got broken by minor vala update in PR #92592.
I haven't tried to understand the problem, hopefully it will be OK.
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jul 26, 2020 •
edited
Loading

@worldofpeace: FYI commit b49e798 (I see you're the pantheon maintainer, too) EDIT: and 28fce08.

vcunat added a commit that referenced this pull request Jul 26, 2020
@vcunat
pantheon: more build fixes by using older vala
28fce08 
An extension of commit b49e798.  /cc PR #92592.
I expect it's "safer" when whole pantheon uses the same version.
Fixes build of wingpanel-indicator-session; maybe some others, too.
Now I built whole pantheon attrset and tests.pantheon.x86_64-linux
@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Jul 26, 2020

Thanks @vcunat, I'll see if I have to write patches or if there's upstream fixes.

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Jul 26, 2020

Interestingly enough I needed this for elementary-files 🤣

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Jul 26, 2020

Fixed in d0c08cf 6df7a93 1e084a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@hedning hedning Awaiting requested review from hedning

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

+1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@worldofpeace @vcunat @jtojnar @jonringer