Skip to content

faustCompressors: temp fix for build#82652

Closed
magnetophon wants to merge 1 commit intoNixOS:masterfrom
magnetophon:faustCompressors
Closed

faustCompressors: temp fix for build#82652
magnetophon wants to merge 1 commit intoNixOS:masterfrom
magnetophon:faustCompressors

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented Mar 15, 2020

The new faust is more strict on it's code checking:
grame-cncm/faust#407

This commit temporarily hacks out some now broken code

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The new faust is more strict on it's code checking:
grame-cncm/faust#407

This commit temporarily hacks out some now broken code
@magnetophon magnetophon mentioned this pull request Mar 15, 2020
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 15, 2020
@magnetophon magnetophon mentioned this pull request Jun 5, 2020
10 tasks
@orivej-nixos
Copy link
Copy Markdown
Contributor

Merged in #82650.

@magnetophon magnetophon deleted the faustCompressors branch August 20, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants