Skip to content

faust2: 2.20.2 -> unstable-2020-03-20#82650

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
magnetophon:faust
Mar 26, 2020
Merged

faust2: 2.20.2 -> unstable-2020-03-20#82650
Mic92 merged 1 commit intoNixOS:masterfrom
magnetophon:faust

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented Mar 15, 2020

Motivation for this change

My update from 2.5.23 to 2.20.2 broke some scripts.

The latest faust release has a bug that makes it unable to compile all of its own libraries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pmahoney March 15, 2020 12:56
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 15, 2020
This was referenced Mar 15, 2020
Closed
Merged
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Mar 21, 2020

I upped the version again, because of grame-cncm/faust#419.

@magnetophon magnetophon mentioned this pull request Mar 23, 2020
Merged
13 tasks
@magnetophon
fixup faust:
3060666 
up version
fix script
temp fix faustCompressors

faust2: 2.20.2 -> unstable-2020-03-20

The latest release has a bug that makes it unable
to compile all of its own libraries:

grame-cncm/faust#406
@Mic92 Mic92 changed the title Faust: make it work again faust2: 2.20.2 -> unstable-2020-03-20 Mar 26, 2020
@Mic92 Mic92 merged commit bbe7624 into NixOS:master Mar 26, 2020
@orivej-nixos orivej-nixos mentioned this pull request Aug 20, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmahoney pmahoney Awaiting requested review from pmahoney

1 more reviewer

@sjfloat sjfloat sjfloat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magnetophon @sjfloat @Mic92