Skip to content

faust: 2.5.23 -> 2.20.2#78613

Merged
FRidh merged 1 commit intoNixOS:masterfrom
magnetophon:faust
Feb 10, 2020
Merged

faust: 2.5.23 -> 2.20.2#78613
FRidh merged 1 commit intoNixOS:masterfrom
magnetophon:faust

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented Jan 27, 2020 •
edited
Loading

Motivation for this change

Some faust scripts only work in nix-shell, see #78610.
In the current faust, one script is broken altogether, this PR fixes that.
Some scripts still don't work in normal shell though...

I'm using llvm_9 cause the default, llvm_7, didn't work.
All the others work, so I figured I'd use the newest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 27, 2020
@FRidh FRidh merged commit bd90b5a into NixOS:master Feb 10, 2020
@magnetophon magnetophon mentioned this pull request Feb 28, 2020
Closed
10 tasks
@magnetophon magnetophon mentioned this pull request Mar 15, 2020
Merged
10 tasks
Artturin
Artturin reviewed Jul 4, 2022
View reviewed changes
pkgs/applications/audio/faust/faust2.nix
substituteInPlace compiler/Makefile.unix \
--replace "5.0.0 5.0.1" "5.0.0 5.0.1 5.0.2"
cmakeFlags = ''
-C ../backends/all.cmake -C ../targets/all.cmake ..
Copy link
Copy Markdown
Member

@Artturin Artturin Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were the trailing .. added on purpose?

#180067

Copy link
Copy Markdown
Member Author

@magnetophon magnetophon Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested without them, and all seems fine, so I guess they weren't on purpose.

@Artturin Artturin mentioned this pull request Jul 5, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Artturin Artturin Artturin left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magnetophon @Artturin @FRidh