FreeBSD packages: Init at 13.1 by Ericson2314 · Pull Request #82131 · NixOS/nixpkgs

Ericson2314 · 2020-03-09T06:17:10Z

Motivation for this change

Have working

nix-build -A pkgsCross.x86_64-freebsd.hello
nix-build -A pkgsCross.x86_64-freebsd.zlib
nix-build -A pkgsCross.x86_64-freebsd.zstd
nix-build -A pkgsCross.x86_64-freebsd.freebsd.sys

~~Running out of memory as NetBSD makeMinimal fails to build. Weird, know what's up @matthewbauer?~~

Oh netbsd make is cached, duh, this is freebsd libc itself.

Things done

CC @wahjava

lib/systems/examples.nix

pkgs/os-specific/bsd/freebsd/default.nix

Ericson2314 · 2020-04-13T05:34:52Z

I dropped link to this in https://forums.freebsd.org/threads/can-i-compile-a-freebsd-kernel-from-linux.64582/, a that is vaguely relevant.

Ericson2314 · 2020-04-20T05:26:34Z

OK need to fix makefiles or bmake itself so non-default system rules -m propagate to recursive make---probably easiest thing to add an environment variable to bmake for this.

pkgs/top-level/all-packages.nix

Ericson2314 · 2022-10-08T03:38:20Z

The kernel builds!

pkgs/os-specific/bsd/xargs-j.sh

pkgs/os-specific/bsd/freebsd/default.nix

pbsds · 2022-10-16T00:40:10Z

I tried building github:Ericson2314/nixpkgs/bsd-cross#pkgsCross.x86_64-freebsd.hello on a arch machine without sandboxing enabled, and got some interesting output:

...
compat> rm: cannot remove '/usr/bin/ppmtopjxl': Permission denied
compat> rm: cannot remove '/usr/bin/nvidia-cuda-mps-control': Permission denied
compat> rm: cannot remove '/usr/bin/weston-simple-shm': Permission denied
compat> rm: cannot remove '/usr/bin/pamdice': Permission denied
compat> rm: cannot remove '/usr/bin/eqn2graph': Permission denied
compat> rm: cannot remove '/usr/bin/curl': Permission denied
compat> rm: cannot remove '/usr/bin/gsdj': Permission denied
...

It seems like it tried to clean the /usr/bin directory on host the machine

SuperSandro2000 · 2022-10-18T21:43:29Z

on a arch machine without sandboxing enabled, and got some interesting output:

Is this required for *bsd's somehow because at this point we mostly ignore errors without sandboxing enabled.

7c6f434c · 2022-10-27T14:34:10Z

pkgs/development/compilers/llvm/12/compiler-rt/default.nix

+  '' + lib.optionalString (doFakeLibgcc) ''
+    ln -s $out/lib/freebsd/libclang_rt.builtins-*.a $out/lib/libgcc.a


Hm, does that mean doFakeLibgcc only works on FreeBSD?

It is just used for FreeBSD right now. I wish we didn't have to do this but the FreeBSD Clang frontend just has these sorts of things hard-coded because that's how FreeBSD currently bootstrap things.

The larger issue is the "OS" field of the target name really has nebulous meaning (is it the syscall ABI, the libc ABI, something more? etc.) and so we get these postels law gone wrong situations of people hacking in ad-hoc special cases to get things working that just cause extra headache for something like Nixpkgs where we rather do all the combinations as uniformly as possible.

9glenda · 2022-10-27T19:30:25Z

Great work

9glenda

I took a quick look at the shell code. It's nothing that bad just really small "mistakes"

pkgs/os-specific/bsd/freebsd/default.nix

9glenda · 2022-10-27T20:01:02Z

Ericson2314#1
I implemented the changes myself and opened a PR

Ericson2314 · 2022-10-31T11:54:21Z

OK I synced the LLVM changes across all the versions. I think this is basically ready to go!

sternenseemann · 2022-11-01T13:29:19Z

lib/systems/parse.nix

IIRC Nix's configure script makes a point of stripping version information from system doubles, so it might be impossible to get such a double as builtins.currentSystem.

You and @alyssais should work that out :) I am not sure what is more correct. If what we have is more correct, that is fine with me we can worry about native compilation later! :D

(i.e. systems that builtins.currentSystem would never produce are not a problem for cross compilation only,)

The libc will be inferred.

A tricky thing about FreeBSD is that there is no stable ABI across versions. That means that putting in the version as part of the config string is paramount. We have a parsed represenation that separates name versus version to accomplish this. We include FreeBSD versions 12 and 13 to demonstrate how it works.

Always set `SRCTOP`, set it with abs path llvmPackages: Bump minimum version for FreeBSD llvmPackages_*, libgcc, compiler_rt: Hack in enough libs that one can compiler C freebsd.compat: Rename some things to work around cc-wrapper change 0bea4a1 / NixOS#191724 in particular

kirillrdy · 2022-11-14T03:52:39Z

Hi, firstly thank you for all the effort that was put into this MR !

unfortunately when i try

nix-build -A pkgsCross.x86_64-freebsd.hello

I get

building '/nix/store/ffa2r42x74j5mfsvkymj9s74w114kqyr-stdenv-linux.drv'...
remote: Enumerating objects: 91213, done.
remote: Counting objects: 100% (91213/91213), done.
remote: Compressing objects: 100% (78514/78514), done.
error: RPC failed; curl 56 OpenSSL SSL_read: error:0A000119:SSL routines::decryption failed or bad record mac, errno 0
error: 5347 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
remote: Enumerating objects: 91213, done.
remote: Counting objects: 100% (91213/91213), done.
remote: Compressing objects: 100% (78514/78514), done.

can someone double check that this builds for others ? just so I know if there is something with my setup

kirillrdy · 2022-11-14T04:17:04Z

hi, actually i found the answer, something is broken with ssl on master, i've rebuild my nixos from previous well known configuration and now it seems to be building

Mic92 · 2022-11-17T19:00:34Z

Is c++ known to work? I just tried cross-compiling patchelf in the patchelf repo and got this:

x86_64-unknown-freebsd13-ld: error: undefined symbol: _Unwind_Resume
>>> referenced by patchelf.cc:0
>>>               patchelf.o:(getElfType(std::__1::shared_ptr<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > const&))
>>> referenced by patchelf.cc:0
>>>               patchelf.o:(error(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&))
>>> referenced by new:0 (/nix/store/qbbik1n6qmmbwhc74fv9czm8qy21cmvf-libcxx-x86_64-unknown-freebsd13-12.0.1-dev/include/c++/v1/new:0)
>>>               patchelf.o:(resolveArgument(char const*))
>>> referenced 81 more times
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)

9glenda · 2022-11-17T19:06:36Z

Finally this is merged

Ericson2314 · 2022-11-17T19:18:28Z

@Mic92 I built zstd and it worked so some C++ does, I thought.

9glenda · 2022-11-17T19:42:14Z

This pr just adds cross compilation support right? Or does it also add support for building the FreeBSD kernel on FreeBSD in case you get nix running there?

Ericson2314 · 2022-11-17T20:00:20Z

@9glenda only cross compilation support, but I did cross compile the kernel too!

Ericson2314 · 2022-11-17T20:01:36Z

My next stop would try to be NetBSD and FreeBSD in https://github.com/cleverca22/not-os. I think just using Nix on stock FreeBSD will actually be harder because modern FreeBSD once to mandate that all syscalls go through the same userland libc --- either we rebuild the entire userland with Nix, or we do impurities.

Mic92 · 2022-11-18T11:47:25Z

It seems that with certain c++ features (i.e. c++17), you need libunwind linked as well.

This is what I added for patchelf to get it working:

  buildInputs = [ llvmPackages.libunwind ];
  NIX_LDFLAGS = "-lunwind";

Probably the macOS version already has something implemented?

Ericson2314 · 2022-11-18T12:08:26Z

pkgs/development/compilers/llvm/10/default.nix

      '' + lib.optionalString (!stdenv.targetPlatform.isWasm) ''
        echo "--unwindlib=libunwind" >> $out/nix-support/cc-cflags
-      '' + lib.optionalString (!stdenv.targetPlatform.isWasm && stdenv.targetPlatform.useLLVM or false) ''
+      '' + lib.optionalString (!stdenv.targetPlatform.isWasm && !stdenv.targetPlatform.isFreeBSD && stdenv.targetPlatform.useLLVM or false) ''


@Mic92 I guess changes like this are adding the problem? But it also didn't work without. Hmm.

Yeah, this seems wrong as we are doing useLLVM

Well forcing -lunwind is a sledgehammer I am skeptical enough, and it was causing failures even if its absense was also causing failures. I think it would be good to figure out why this was needed in the first place.

Ericson2314 requested a review from matthewbauer March 9, 2020 06:17

Ericson2314 requested a review from nbp as a code owner March 9, 2020 06:17

ofborg bot added 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 9, 2020

vcunat reviewed Mar 9, 2020

View reviewed changes

lib/systems/examples.nix Outdated Show resolved Hide resolved

wahjava reviewed Mar 11, 2020

View reviewed changes

pkgs/os-specific/bsd/freebsd/default.nix Outdated Show resolved Hide resolved

Ericson2314 force-pushed the bsd-cross branch from 2ef3192 to f9faf73 Compare April 13, 2020 05:25

Ericson2314 force-pushed the bsd-cross branch from f9faf73 to aaefaf0 Compare April 20, 2020 05:20

Ericson2314 changed the title ~~WIP: Free BSD cross compilation~~ WIP: Add FreeBSD and fix NetBSD cross compilation Apr 20, 2020

Ericson2314 mentioned this pull request Apr 20, 2020

Fix FreeBSD support #81459

Closed

10 tasks

ofborg bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2020

Ericson2314 force-pushed the bsd-cross branch from aaefaf0 to 3c4f007 Compare May 20, 2020 02:10

Ericson2314 force-pushed the bsd-cross branch from 3c4f007 to a354181 Compare August 7, 2020 17:30

ofborg bot requested review from dtzWill and peti August 7, 2020 18:12

ryantm marked this pull request as draft October 23, 2020 03:02

SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021

SuperSandro2000 reviewed Apr 14, 2021

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

alyssais mentioned this pull request Apr 14, 2021

fetch{cvs,svn}: Hack around splicing annoyance #119465

Merged

10 tasks

Ericson2314 force-pushed the bsd-cross branch from a354181 to 80c502e Compare April 14, 2021 21:57

SuperSandro2000 reviewed Oct 8, 2022

View reviewed changes

pkgs/os-specific/bsd/xargs-j.sh Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Oct 8, 2022

View reviewed changes

pkgs/os-specific/bsd/xargs-j.sh Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Oct 8, 2022

View reviewed changes

pkgs/os-specific/bsd/freebsd/default.nix Outdated Show resolved Hide resolved

7c6f434c reviewed Oct 27, 2022

View reviewed changes

9glenda approved these changes Oct 27, 2022

View reviewed changes

9glenda reviewed Oct 27, 2022

View reviewed changes

pkgs/os-specific/bsd/freebsd/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/bsd/freebsd/default.nix Outdated Show resolved Hide resolved

Ericson2314 mentioned this pull request Nov 1, 2022

🦝 NixOS 22.11 - Feature Freeze & Release Blockers #194208

Closed

31 tasks

sternenseemann reviewed Nov 1, 2022

View reviewed changes

Ericson2314 mentioned this pull request Nov 4, 2022

New GCC packaging -- separating compilers from runtime libraries #132340

Open

Ericson2314 and others added 3 commits November 4, 2022 16:49

lib/systems: Simplify NetBSD examples

f172d86

The libc will be inferred.

rrbutani mentioned this pull request Nov 7, 2022

llvmPackages_15: init at 15.0.7 #194634

Merged

92 tasks

ghost mentioned this pull request Nov 14, 2022

lib/systems/parse.nix: mkSkeletonFromList: improve readability #180964

Merged

3 tasks

Ericson2314 commented Nov 18, 2022

View reviewed changes

		'' + lib.optionalString (doFakeLibgcc) ''
		ln -s $out/lib/freebsd/libclang_rt.builtins-*.a $out/lib/libgcc.a

Uh oh!

Conversation

Ericson2314 commented Mar 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

Uh oh!

Uh oh!

Ericson2314 commented Apr 13, 2020

Uh oh!

Ericson2314 commented Apr 20, 2020

Uh oh!

Uh oh!

Ericson2314 commented Oct 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbsds commented Oct 16, 2022

Uh oh!

SuperSandro2000 commented Oct 18, 2022

Uh oh!

7c6f434c Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

Ericson2314 Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

9glenda commented Oct 27, 2022

Uh oh!

9glenda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

9glenda commented Oct 27, 2022

Uh oh!

Ericson2314 commented Oct 31, 2022

Uh oh!

sternenseemann Nov 1, 2022

Choose a reason for hiding this comment

Uh oh!

Ericson2314 Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirillrdy commented Nov 14, 2022

Uh oh!

kirillrdy commented Nov 14, 2022

Uh oh!

Mic92 commented Nov 17, 2022

Uh oh!

9glenda commented Nov 17, 2022

Uh oh!

Ericson2314 commented Nov 17, 2022

Uh oh!

9glenda commented Nov 17, 2022

Uh oh!

Ericson2314 commented Nov 17, 2022

Uh oh!

Ericson2314 commented Nov 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mic92 commented Nov 18, 2022

Uh oh!

Ericson2314 Nov 18, 2022

Choose a reason for hiding this comment

Uh oh!

sternenseemann Nov 18, 2022

Choose a reason for hiding this comment

Uh oh!

Ericson2314 Nov 18, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Ericson2314 commented Mar 9, 2020 •

edited

Loading

Ericson2314 Nov 1, 2022 •

edited

Loading

Ericson2314 commented Nov 17, 2022 •

edited

Loading