Minior changes to shell code#1
Merged
Ericson2314 merged 1 commit intoEricson2314:bsd-crossfrom Oct 31, 2022
9glenda:bsd-cross
Merged
Minior changes to shell code#1Ericson2314 merged 1 commit intoEricson2314:bsd-crossfrom 9glenda:bsd-cross
Ericson2314 merged 1 commit intoEricson2314:bsd-crossfrom
9glenda:bsd-cross
Conversation
10 tasks
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Cleaner code
Things done
Mainly added quotes where they are generally recommended to use
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Hopefully I didn't break any build steps which I am pretty sure I didn't but I wasn't able to figure out how to test rather my code still builds.