Skip to content

nixosTests.krb5: Port to python#80130

Merged
worldofpeace merged 2 commits intoNixOS:masterfrom
tfc:port-krb5-test
Feb 14, 2020
Merged

nixosTests.krb5: Port to python#80130
worldofpeace merged 2 commits intoNixOS:masterfrom
tfc:port-krb5-test

Conversation

@tfc
Copy link
Copy Markdown
Contributor

@tfc tfc commented Feb 14, 2020 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc requested review from flokli and worldofpeace February 14, 2020 18:08
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 14, 2020
worldofpeace
worldofpeace approved these changes Feb 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works.

@worldofpeace worldofpeace merged commit 5bb3eaa into NixOS:master Feb 14, 2020
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Feb 14, 2020

Thanks ✨

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
@worldofpeace @dtzWill
Merge pull request NixOS#80130 from tfc/port-krb5-test
6a01aa7 
nixosTests.krb5: Port to python

(cherry picked from commit 5bb3eaa)
@tfc tfc deleted the port-krb5-test branch February 15, 2020 14:26
@tfc tfc mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli Awaiting requested review from flokli

1 more reviewer

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tfc @worldofpeace