Skip to content

nixosTests.run-in-machine: Port to Python#80099

Merged
worldofpeace merged 2 commits intoNixOS:masterfrom
tfc:port-run-in-machine-test
Feb 18, 2020
Merged

nixosTests.run-in-machine: Port to Python#80099
worldofpeace merged 2 commits intoNixOS:masterfrom
tfc:port-run-in-machine-test

Conversation

@tfc
Copy link
Copy Markdown
Contributor

@tfc tfc commented Feb 14, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Feb 14, 2020 •
edited
Loading

@GrahamcOfBorg test run-in-machine

@tfc tfc requested review from flokli and worldofpeace February 14, 2020 07:53
@tfc tfc mentioned this pull request Feb 14, 2020
Closed
@veprbl veprbl added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 14, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 14, 2020
@tfc tfc changed the title Port run in machine test nixosTests.run-in-machine: Port to Python Feb 14, 2020
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Feb 14, 2020

@tfc Oh no, forgot to merge #79659.

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Feb 14, 2020

Can you have the PR have only 8dffaca and 39174b8?

@tfc tfc force-pushed the port-run-in-machine-test branch from 39174b8 to 965c178 Compare February 14, 2020 18:05
@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Feb 14, 2020

Can you have the PR have only 8dffaca and 39174b8?

@worldofpeace done

@worldofpeace worldofpeace merged commit c4de30c into NixOS:master Feb 18, 2020
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Feb 18, 2020

Thanks @tfc ❤️

@tfc tfc deleted the port-run-in-machine-test branch February 25, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli Awaiting requested review from flokli

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tfc @worldofpeace @veprbl