testing: fix runInMachineWithX/runInMachine#79659
Merged
worldofpeace merged 3 commits intoNixOS:masterfrom Feb 14, 2020
Merged
Conversation
The test script's were unported. It's unclear whether the preBuild or postBuild will work as expect, due to the linting of the test scripts.
we import it for the runInMachineWithX
flokli
approved these changes
Feb 10, 2020
10 tasks
Contributor
Author
|
Need to backport this. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is for both the python and perl driver.
The both shared the same breakage from c95612a, and the python driver had unported testing scripts for these functions.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)