Skip to content

nixosTests.limesurvey: port to python and drop badly utf encoded characters #78555

Merged
worldofpeace merged 3 commits intoNixOS:masterfrom
tfc:limesurvey-utf8
Jan 27, 2020
Merged

nixosTests.limesurvey: port to python and drop badly utf encoded characters #78555
worldofpeace merged 3 commits intoNixOS:masterfrom
tfc:limesurvey-utf8

Conversation

@tfc
Copy link
Copy Markdown
Contributor

@tfc tfc commented Jan 26, 2020

Motivation for this change

#72828

Things done

I also dropped badly encoded utf chars in the command execution output.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @flokli @worldofpeace

@tfc tfc mentioned this pull request Jan 26, 2020
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 26, 2020
@tfc tfc mentioned this pull request Jan 26, 2020
Merged
10 tasks
@tfc tfc force-pushed the limesurvey-utf8 branch from d47bd84 to ee2acd6 Compare January 26, 2020 16:12
@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Jan 26, 2020

Also added proxy to this PR (moved away from #78556) because it would also suffer from the utf thing

@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Jan 26, 2020

@GrahamcOfBorg test limesurvey proxy

worldofpeace
worldofpeace approved these changes Jan 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 839be38 into NixOS:master Jan 27, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@worldofpeace @dtzWill
Merge pull request NixOS#78555 from tfc/limesurvey-utf8
3831aa9 
nixosTests.limesurvey: port to python and drop badly utf encoded characters

(cherry picked from commit 839be38)
@tfc tfc deleted the limesurvey-utf8 branch January 27, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tfc @worldofpeace