nixosTests.networkingProxy: port to Python#78239
Conversation
ab0a080 to
e818a1a
Compare
|
@tfc - Yep, can do for both. As a general question: for these sorts of "porting tests" PRs, would it be better to do a mechanical line-by-line translation (like I did here), or a more general rewrite? |
this is what i did when the whole project began, as i don't understand how all of the tested services really work. Then a 1:1 port was the minimal feasible thing to do.
If you are the maintainer of the service, the test, or simply happen to know how the tested service really works and ought to be tested, a rewrite that makes it better/more readable/more structured is always welcome! |
e818a1a to
8507f84
Compare
8507f84 to
ec15ea0
Compare
|
@GrahamcOfBorg test networkingProxy |
ec15ea0 to
36d1141
Compare
|
Fixed commit message. |
…tests-python nixosTests.networkingProxy: port to Python
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)Notify maintainers
cc @tfc @ardumont