Skip to content

cinnamon.nemo: init at 4.4.1#77979

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
mkg20001:pkg/nemo
Jan 22, 2020
Merged

cinnamon.nemo: init at 4.4.1#77979
worldofpeace merged 1 commit intoNixOS:masterfrom
mkg20001:pkg/nemo

Conversation

@mkg20001
Copy link
Copy Markdown
Member

@mkg20001 mkg20001 commented Jan 18, 2020

Motivation for this change

Needed for cinnamon porting

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nh2
nh2 requested changes Jan 19, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/default.nix Outdated
nh2
nh2 reviewed Jan 19, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/default.nix Outdated
@mkg20001 mkg20001 mentioned this pull request Jan 20, 2020
Merged
10 tasks
worldofpeace
worldofpeace reviewed Jan 20, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/0002-patch-remove-update-mime-db-script.patch Outdated
worldofpeace
worldofpeace reviewed Jan 20, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/0001-patch-datadir.patch Outdated
worldofpeace
worldofpeace reviewed Jan 20, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/default.nix Outdated
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 20, 2020
mkg20001
mkg20001 commented Jan 20, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/0001-patch-datadir.patch Outdated
@worldofpeace worldofpeace requested a review from jtojnar January 20, 2020 01:52
nh2
nh2 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, nemo works for me now.

Approving, but I think you should also switch to the approach shown in #77979 (comment) for this and all other all new meson packages.

@nh2 nh2 mentioned this pull request Jan 20, 2020
Open
24 tasks
worldofpeace
worldofpeace reviewed Jan 22, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/default.nix Outdated
worldofpeace
worldofpeace suggested changes Jan 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a dev output also?

@worldofpeace worldofpeace mentioned this pull request Jan 22, 2020
Closed
@mkg20001 mkg20001 force-pushed the pkg/nemo branch 2 times, most recently from fb0af37 to 31de7fd Compare January 22, 2020 21:39
worldofpeace
worldofpeace reviewed Jan 22, 2020
View reviewed changes
Comment thread pkgs/desktops/cinnamon/nemo/default.nix Outdated
@worldofpeace worldofpeace merged commit 17bdd50 into NixOS:master Jan 22, 2020
This was referenced Feb 6, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nh2 nh2 nh2 approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

+1 more reviewer

@worldofpeace worldofpeace worldofpeace requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkg20001 @nh2 @jtojnar @worldofpeace