Skip to content

nextcloud-client: disable shibboleth#75202

Merged
Ma27 merged 1 commit intoNixOS:masterfrom
veprbl:pr/nextcloud_rm_qtwebkit
Dec 14, 2019
Merged

nextcloud-client: disable shibboleth#75202
Ma27 merged 1 commit intoNixOS:masterfrom
veprbl:pr/nextcloud_rm_qtwebkit

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Dec 8, 2019 •
edited
Loading

Motivation for this change

The expression already uses qtwebengine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @caugner @Ma27

@veprbl veprbl mentioned this pull request Dec 8, 2019
Closed
69 tasks
@ofborg ofborg bot requested a review from Ma27 December 8, 2019 04:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2019
@veprbl
nextcloud-client: disable shibboleth
61b7d24 
Allows to remove qtwebkit dependency
@veprbl veprbl force-pushed the pr/nextcloud_rm_qtwebkit branch from d3d201a to 61b7d24 Compare December 8, 2019 04:38
@veprbl veprbl changed the title nextcloud-client: remove unused qtwebkit dependency nextcloud-client: remove qtwebkit dependency Dec 8, 2019
@veprbl veprbl changed the title nextcloud-client: remove qtwebkit dependency nextcloud-client: disable shibboleth Dec 8, 2019
@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Dec 8, 2019

I made a similar PR for owncloud-client: #75206
Also notice that owncloud-client upstream has removed the feature completely: owncloud/client@697b6b9

@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Dec 8, 2019 •
edited
Loading

nextcloud-clients upstream builds their images with this option:
https://github.com/nextcloud/desktop/blob/c7299dec78303a72192e1d4d666f91fe5798eae9/.drone.yml#L25

@aanderse
Copy link
Copy Markdown
Member

aanderse commented Dec 8, 2019

What does shibboleth have to do with qt at all...? 🤔

@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Dec 8, 2019 •
edited
Loading

I would guess, it serves some sort of authentication form via html+http, so you need a full web browser to display it?

@aanderse
Copy link
Copy Markdown
Member

aanderse commented Dec 9, 2019

Interesting. I learn something new every day. 😄

@Ma27
Copy link
Copy Markdown
Member

Ma27 commented Dec 14, 2019

aarch64 build currently fails due to qtwebengine. Apart from this, LGTM 👍

@Ma27 Ma27 merged commit ce23582 into NixOS:master Dec 14, 2019
@veprbl veprbl deleted the pr/nextcloud_rm_qtwebkit branch December 1, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@veprbl @aanderse @Ma27 @bjornfor