Skip to content

owncloud-client: disable shibboleth#75206

Merged
Lassulus merged 1 commit intoNixOS:masterfrom
veprbl:pr/owncloud_rm_qtwebkit
Dec 8, 2019
Merged

owncloud-client: disable shibboleth#75206
Lassulus merged 1 commit intoNixOS:masterfrom
veprbl:pr/owncloud_rm_qtwebkit

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Dec 8, 2019

Motivation for this change

Allows to remove qtwebkit dependency.
Upstream removed the option:
owncloud/client@697b6b9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This was referenced Dec 8, 2019
Merged
Closed
@ofborg ofborg bot requested a review from qknight December 8, 2019 05:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2019
Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review and connected to an ownloud server

@Lassulus Lassulus merged commit 302a0be into NixOS:master Dec 8, 2019
@veprbl veprbl deleted the pr/owncloud_rm_qtwebkit branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lassulus Lassulus Lassulus approved these changes

@qknight qknight Awaiting requested review from qknight

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veprbl @Lassulus