Merged
Conversation
osquery was marked as broken since April. If somebody steps up to fix it, we can always revive it from the histroy, but there's not much value in shipping completely broken things in current master. cc @Ma27
10 tasks
Member
|
Ping @Ma27 who indicated in #58834 (comment) to look into fixing the build (Edit: Oh you already pinged them, duh) |
Ma27
approved these changes
Nov 24, 2019
Member
Ma27
left a comment
There was a problem hiding this comment.
I don't use osquery anymore. I tried to look into this several times, but the build system is pretty complex (also due to our cmake-related patches for osquery).
I don't have the time and motivation atm to fix this, so if noone else steps up, I'd be fine with removing it.
Member
Author
|
So let's remove it. If somebody wants to get it going before the next release, we can add it back and remove it from the changelog. |
Ma27
added a commit
that referenced
this pull request
Dec 2, 2019
The package has been removed in #74081.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osquery was marked as broken since April.
If somebody steps up to fix it, we can always revive it from the
histroy, but there's not much value in shipping completely broken things
in current master.
cc @Ma27
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)