Skip to content

nixosTests.osquery: port to python#74073

Closed
Br1ght0ne wants to merge 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.osquery-python
Closed

nixosTests.osquery: port to python#74073
Br1ght0ne wants to merge 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.osquery-python

Conversation

@Br1ght0ne
Copy link
Copy Markdown
Member

@Br1ght0ne Br1ght0ne commented Nov 24, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma27

This change is Reviewable

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 24, 2019
@tfc tfc mentioned this pull request Nov 24, 2019
Closed
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 24, 2019

Thanks for bumping the test! Unfortunately, it seems osquery is broken since quite some time, so we can't really test this test actually works. I opened #74081 to remove osquery entirely, so we can probably close this PR.

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 24, 2019

osquery was removed, so closing this PR. Sorry for the inconvenience!

@flokli flokli closed this Nov 24, 2019
@Br1ght0ne
Copy link
Copy Markdown
Member Author

Br1ght0ne commented Nov 25, 2019

No problem, thanks for letting me know @flokli! I'll port something later :)

@Br1ght0ne Br1ght0ne deleted the nixosTests.osquery-python branch November 27, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Br1ght0ne @flokli