Skip to content

nixosTests.gnome3-xorg: port to python/rewrite#73938

Merged
worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace:port-gnome3-xorg-test
Jan 8, 2020
Merged

nixosTests.gnome3-xorg: port to python/rewrite#73938
worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace:port-gnome3-xorg-test

Conversation

@worldofpeace
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace commented Nov 22, 2019 •
edited
Loading

Motivation for this change

This test unfortunately doesn't work properly with this port.
It fails at the call to

machine.wait_for_unit("gnome-session-x11@gnome.target", "${user.name}")

with error: unit "gnome-session-x11@gnome.target" is inactive and there are no pending jobs.

Also, how I set the default session here is not really what I want.
I wrote #73378 shortly after this because bash... yeah no.

Rebased because that code is now merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace mentioned this pull request Nov 22, 2019
Closed
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 22, 2019
@worldofpeace
nixos/tests/user-account: add static uid for alice
e2ea815 
A lot of tests assume that the alice user
will have a uid of 1000. Let's make that
a guarantee and be able to reference this value.
@worldofpeace
nixosTests.gnome3-xorg: port to python/rewrite
228818c 
We've rewritten it use GDM, and we can now autologin
to the X11 session because of the accountsservice preStart
script for autologin. It should work similar to how the wayland
test works, just with a few nuanced differences for xorg.
@worldofpeace worldofpeace changed the title nixosTests.gnome3-xorg: port to python nixosTests.gnome3-xorg: port to python/rewrite Dec 22, 2019
@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Dec 22, 2019

I've made this match the gnome3.nix test because that works reliably. Until the python driver doesn't poll the cli for waiting on systemd units, using them in this test will not work.

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Dec 22, 2019

@GrahamcOfBorg test gnome3-xorg

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Dec 22, 2019

Note the wmclass of gnome-terminal is specifically Gnome-terminal for some reason on xorg.

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Dec 22, 2019

In a followup I'd like to try testing gnome-inital-setup. Mostly closing it and yelp that gets spawned afterwards.

@worldofpeace worldofpeace merged commit a408bcb into NixOS:master Jan 8, 2020
@worldofpeace worldofpeace deleted the port-gnome3-xorg-test branch January 8, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@worldofpeace