nixos/gdm: make desktopManager.default work#73378
Merged
worldofpeace merged 1 commit intoNixOS:masterfrom Nov 22, 2019
Merged
Conversation
Contributor
I think it should work, every dm+wm combo gets it's own |
Contributor
Author
Oh, thanks for clearing that up. I wasn't sure if they were named that way. |
jtojnar
requested changes
Nov 14, 2019
Contributor
Author
|
Ok, let's use OrderedSet and set comprehension. |
jtojnar
reviewed
Nov 15, 2019
10 tasks
Unfortunately, you can't configure the default user-session with GDM like lightdm. I've opened a feature request [0] but I'd like to be able to do this now. We use a GObject Python script using bindings to AccountsService to achieve this. I'm hoping the reliable heuristic for session names is the file's basename. We also have some special logic for which method to use to set the default session. It seems set_x_session is deprecated, and thusly the XSession key, but if that method isn't used when it's an xsession it won't be the default in GDM. [0]: https://gitlab.gnome.org/GNOME/gdm/issues/535
4c79ba5 to
d8b50bf
Compare
worldofpeace
added a commit
that referenced
this pull request
Nov 22, 2019
jtojnar
added a commit
to jtojnar/nixfiles
that referenced
this pull request
Dec 30, 2019
GDM keeps defaulting to xterm for me Probably caused by NixOS/nixpkgs#73378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unfortunately, you can't configure the default user-session
with GDM like lightdm. I've opened a feature request 0
but I'd like to be able to do this now.
We use a GObject Python script using bindings to AccountsService
to achieve this. I'm hoping the reliable heuristic for session names
is the file's basename. We also have some special logic for which
method to use to set the default session. It seems set_x_session is
deprecated, and thusly the XSession key, but if that method isn't used
when it's an xsession it won't be the default in GDM.
I'm not sure this will work right with desktopManager + windowManager
Things done
Played with a vm with multiple users and if all their default sessions were as I declared.
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @