Port remaining test-driver functions to python#72943
Merged
worldofpeace merged 2 commits intoNixOS:masterfrom Nov 7, 2019
Merged
Port remaining test-driver functions to python#72943worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace merged 2 commits intoNixOS:masterfrom
Conversation
tfc
approved these changes
Nov 7, 2019
Contributor
worldofpeace
approved these changes
Nov 7, 2019
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 10, 2019
Port remaining test-driver functions to python (cherry picked from commit 1e7ddf2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Processing the task list in issue #72828.
Implementation of dumpTTYContents and forwardPort.
Note: Both functions are not used in any test so far.
Things done
The functions conform the Black code style.
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @tfc @flokli @worldofpeace