Remove altcoins set and create blockchains section#67687
Merged
mmahut merged 4 commits intoNixOS:masterfrom Aug 29, 2019
Merged
Remove altcoins set and create blockchains section#67687mmahut merged 4 commits intoNixOS:masterfrom
mmahut merged 4 commits intoNixOS:masterfrom
Conversation
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
This is no longer needed Signed-off-by: William Casarin <jb55@jb55.com>
Member
|
Thank you for the effort! This looks good to me, if ofborg doesn't complain I think we can merge it. |
jonringer
approved these changes
Aug 29, 2019
Contributor
jonringer
left a comment
There was a problem hiding this comment.
nix-review passes on NixOS (no rebuilds)
diff LGTM
[1 built, 50 copied (1179.0 MiB), 257.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67687
5 package are marked as broken and were skipped:
dcrd dcrwallet freicoin pivx pivxd
24 package were build:
aeon bitcoin-abc bitcoin-classic bitcoin-unlimited bitcoind bitcoind-abc bitcoind-classic bitcoind-unlimited btc1 btc1d dashpay dero dogecoin dogecoind go-ethereum-classic litecoin litecoind masari mist namecoin namecoind sumokoin wownero zcash
Member
|
@jb55 one more thing I forgot - do you mind to put this change in |
jb55
added a commit
to jb55/nixpkgs
that referenced
this pull request
Sep 1, 2019
Release notes for NixOS#67687 (bc08b42) [1] Related issue: NixOS#25025 [2] [1] NixOS#67687 [2] NixOS#25025 Suggested-by: @mmahut Signed-off-by: William Casarin <jb55@jb55.com>
10 tasks
Contributor
Author
Member
|
@jb55 thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Altcoins was always a strange name for this type of software. Bitcoin was categorized as an "altcoin" which is pretty confusing/strange. See #25025 for why blockchains was chosen, but happy to hear alternatives.
This removes the altcoins set and splays them into all-packages in a new
blockchainssection.Fixes #25025
Things
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @mmahut @chris-martin