pulseview,pavucontrol-qt: use qt5.mkDerivation#65366
pulseview,pavucontrol-qt: use qt5.mkDerivation#65366delroth wants to merge 1 commit intoNixOS:masterfrom
Conversation
|
(@ttuegel) |
bjornfor
left a comment
There was a problem hiding this comment.
Please add "I've noticed both of these apps don't start anymore due to missing Qt plugin path." or something to the commit message (the why part).
|
@ttuegel Would it be possible to open a tracking issue so people to explain to people how then can easily migrate to the qt wrappers? The influx of PRs like this is going to be large, so it would be easy to track if each one opened would reference that single issue also. |
The apps currently do not start because of a missing QT_PLUGIN_PATH.
|
Addressed both comments. |
|
I'm now a bit confused whether expressions should use the qt5 package set directly or not, see #65399 (comment). But anyway, please split the commit in two, one for each package you're updating. |
|
No more confusion, this is how to do it: #65399 (comment). |
| { stdenv, fetchurl, pkgconfig, cmake, glib, boost, libsigrok | ||
| , libsigrokdecode, libserialport, libzip, udev, libusb1, libftdi1, glibmm | ||
| , pcre, librevisa, python3, qtbase, qtsvg | ||
| , pcre, librevisa, python3, qt5, qtbase, qtsvg |
There was a problem hiding this comment.
| , pcre, librevisa, python3, qt5, qtbase, qtsvg | |
| , pcre, librevisa, python3, mkDerivation, qtbase, qtsvg |
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| qt5.mkDerivation rec { |
There was a problem hiding this comment.
| qt5.mkDerivation rec { | |
| mkDerivation rec { |
| @@ -1,7 +1,7 @@ | |||
| { stdenv, fetchFromGitHub, cmake, pkgconfig, lxqt, libpulseaudio, | |||
| pcre, qtbase, qttools, qtx11extras }: | |||
| pcre, qt5, qtbase, qttools, qtx11extras }: | |||
There was a problem hiding this comment.
| pcre, qt5, qtbase, qttools, qtx11extras }: | |
| pcre, mkDerivation, qtbase, qttools, qtx11extras }: |
| pcre, qt5, qtbase, qttools, qtx11extras }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| qt5.mkDerivation rec { |
There was a problem hiding this comment.
| qt5.mkDerivation rec { | |
| mkDerivation rec { |
|
We should never use |
Motivation for this change
I've noticed both of these apps don't start anymore due to missing Qt plugin path.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)